-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports custom prepare build script #1490
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1490 +/- ##
==========================================
+ Coverage 35.91% 43.45% +7.54%
==========================================
Files 69 76 +7
Lines 11576 12320 +744
==========================================
+ Hits 4157 5354 +1197
+ Misses 7104 6630 -474
- Partials 315 336 +21 |
默认脚本是不是可以放在.buildrc里,和go保持一致 |
昨天看了下,gcc那些依赖是ai-data-masking项目里的正则库依赖的,不是一个通用依赖 |
是的,我的意思是要在这里增加支持 prepare 脚本的逻辑 |
参考这里 higress/.github/workflows/build-and-push-wasm-plugin-image.yaml Lines 111 to 117 in aee37c5
|
go也没有修改 prepare 脚本的逻辑把,rust和go可以统一固定为插件目录下的 .buildrc |
改成.buildrc了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a change request and no relation with fixed PR but no way to resolve it, PTAL @johnlanni |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Nowadays, if some plugin has additional dependencies need to be installed, developer may change the builder Dockerfile directly, but it's not healthy for long time maintaining.
This PR will support custom prepare build script for each plugin.