Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports custom prepare build script #1490

Merged
merged 7 commits into from
Nov 12, 2024

Conversation

jizhuozhi
Copy link
Collaborator

Ⅰ. Describe what this PR did

Nowadays, if some plugin has additional dependencies need to be installed, developer may change the builder Dockerfile directly, but it's not healthy for long time maintaining.

This PR will support custom prepare build script for each plugin.

@jizhuozhi jizhuozhi requested a review from 007gzs as a code owner November 7, 2024 15:27
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.45%. Comparing base (ef31e09) to head (3899ec0).
Report is 196 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   35.91%   43.45%   +7.54%     
==========================================
  Files          69       76       +7     
  Lines       11576    12320     +744     
==========================================
+ Hits         4157     5354    +1197     
+ Misses       7104     6630     -474     
- Partials      315      336      +21     

see 69 files with indirect coverage changes

johnlanni

This comment was marked as outdated.

@007gzs
Copy link
Collaborator

007gzs commented Nov 8, 2024

默认脚本是不是可以放在.buildrc里,和go保持一致

@007gzs
Copy link
Collaborator

007gzs commented Nov 8, 2024

The action also needs to be updated accordingly:

cd /workspace/plugins/wasm-rust/extensions/${PLUGIN_NAME}

昨天看了下,gcc那些依赖是ai-data-masking项目里的正则库依赖的,不是一个通用依赖

@johnlanni
Copy link
Collaborator

The action also needs to be updated accordingly:

cd /workspace/plugins/wasm-rust/extensions/${PLUGIN_NAME}

昨天看了下,gcc那些依赖是ai-data-masking项目里的正则库依赖的,不是一个通用依赖

是的,我的意思是要在这里增加支持 prepare 脚本的逻辑

@007gzs
Copy link
Collaborator

007gzs commented Nov 8, 2024

参考这里

cd ${{ github.workspace }}/plugins/wasm-${PLUGIN_TYPE}/extensions/${PLUGIN_NAME}
if [ -f ./.buildrc ]; then
echo 'Found .buildrc file, sourcing it...'
. ./.buildrc
else
echo '.buildrc file not found'
fi

@007gzs
Copy link
Collaborator

007gzs commented Nov 8, 2024

go也没有修改 prepare 脚本的逻辑把,rust和go可以统一固定为插件目录下的 .buildrc

@jizhuozhi
Copy link
Collaborator Author

改成.buildrc了

Copy link
Collaborator

@007gzs 007gzs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jizhuozhi jizhuozhi requested a review from johnlanni November 12, 2024 03:46
@jizhuozhi
Copy link
Collaborator Author

There is a change request and no relation with fixed PR but no way to resolve it, PTAL @johnlanni

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 6a1bf90 into alibaba:main Nov 12, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants