Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ai-proxy support custom error handler by cover util.ErrorHandler #1537

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

pepesi
Copy link
Contributor

@pepesi pepesi commented Nov 22, 2024

Ⅰ. Describe what this PR did

解决如 #1532 描述的问题,允许替换错误处理部分,添加自定义逻辑

Ⅱ. Does this pull request fix one issue?

#1532

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.52%. Comparing base (ef31e09) to head (f7e8718).
Report is 218 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1537      +/-   ##
==========================================
+ Coverage   35.91%   43.52%   +7.61%     
==========================================
  Files          69       76       +7     
  Lines       11576    12325     +749     
==========================================
+ Hits         4157     5365    +1208     
+ Misses       7104     6625     -479     
- Partials      315      335      +20     

see 69 files with indirect coverage changes

@pepesi pepesi force-pushed the feat-custom-proxy-error branch from 8db8e45 to a25be3f Compare November 22, 2024 09:31
@pepesi pepesi changed the title feat: ai-proxy support custom error handler by cover DefaultErrorHandler feat: ai-proxy support custom error handler by cover util.ErrorHandler Nov 22, 2024
@pepesi pepesi force-pushed the feat-custom-proxy-error branch 2 times, most recently from 3da7424 to 9517b51 Compare December 2, 2024 09:52
@pepesi pepesi force-pushed the feat-custom-proxy-error branch from 9517b51 to f7e8718 Compare December 5, 2024 04:05
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 8f66021 into alibaba:main Dec 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants