Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pilot debug APIs support remote anonymous requests #386

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Jun 18, 2023

Ⅰ. Describe what this PR did

Make pilot debug APIs support remote anonymous requests, so we don't need to generate an access token on purpose for Higress Console in standalone deployment.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Merging #386 (6a99511) into main (51d7124) will increase coverage by 0.17%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #386      +/-   ##
==========================================
+ Coverage   41.56%   41.73%   +0.17%     
==========================================
  Files          44       44              
  Lines        5877     5877              
==========================================
+ Hits         2443     2453      +10     
+ Misses       3261     3251      -10     
  Partials      173      173              

see 1 file with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit ac2f0a5 into alibaba:main Jun 19, 2023
@CH3CHO CH3CHO deleted the feat/pilot-debug-api-anony branch June 19, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants