Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(main): fix test coverage panic permission denied in darwin/arm64 #741

Merged
merged 2 commits into from
Jan 12, 2024

Conversation

LZiHaN
Copy link
Contributor

@LZiHaN LZiHaN commented Dec 29, 2023

Ⅰ. Describe what this PR did

the issue has been resolved in the latest version of the gomonkey repo.

Ⅱ. Does this pull request fix one issue?

fixes #539
refer to agiledragon/gomonkey#142

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

exec 'make go.test.coverage' on darwin/arm64.

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (85df257) 33.97% compared to head (6c66d11) 34.05%.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   33.97%   34.05%   +0.08%     
==========================================
  Files          78       78              
  Lines       11204    11204              
==========================================
+ Hits         3806     3816      +10     
+ Misses       7105     7096       -9     
+ Partials      293      292       -1     

see 1 file with indirect coverage changes

@johnlanni johnlanni merged commit a71ecf4 into alibaba:main Jan 12, 2024
8 checks passed
@LZiHaN LZiHaN deleted the bugfix-testcoverage branch January 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make go.test.coverage met panic: permission denied in darwin/arm64
4 participants