-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: e2e test opt #746
feat: e2e test opt #746
Conversation
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #746 +/- ##
==========================================
+ Coverage 38.11% 38.17% +0.05%
==========================================
Files 61 61
Lines 10323 10342 +19
==========================================
+ Hits 3935 3948 +13
- Misses 6089 6096 +7
+ Partials 299 298 -1 |
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
9c57b0a
to
d5092f3
Compare
Signed-off-by: sjcsjc123 <1401189096@qq.com>
# Conflicts: # Makefile.core.mk # test/e2e/conformance/utils/suite/suite.go # test/e2e/e2e_test.go
048db2d
to
c481798
Compare
# Conflicts: # test/e2e/conformance/utils/suite/suite.go # test/e2e/e2e_test.go
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
b1284db
to
4f8d074
Compare
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
cc @2456868764 |
# Conflicts: # test/e2e/conformance/utils/suite/suite.go
Signed-off-by: sjcsjc123 <1401189096@qq.com>
6b17394
to
644e064
Compare
@2456868764 已取消移除cleanup参数,不过只能放在TestClean方法上,三个func不共享testing.T,会在prepare阶段就把base resource给清理了 |
Signed-off-by: sjcsjc123 <1401189096@qq.com>
# Conflicts: # test/e2e/e2e_test.go
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
LGTM |
https://github.com/alibaba/higress/tree/main/test @sjcsjc123 请更新一下这篇README ,补充下在本地运行e2e test时复用环境的建议 |
Signed-off-by: sjcsjc123 <1401189096@qq.com>
已添加 |
@@ -27,4 +27,5 @@ var ( | |||
WasmPluginType = flag.String("wasmPluginType", "GO", "Define wasm plugin type, currently supports GO, CPP") | |||
WasmPluginName = flag.String("wasmPluginName", "", "Define wasm plugin name") | |||
IsEnvoyConfigTest = flag.Bool("isEnvoyConfigTest", false, "Determine if run envoy config conformance test") | |||
TestArea = flag.String("test-area", "all", "Test area to run, like all to run setup/run/clean, setup to run setup only, run to run run only, clean to run clean only") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"run to run run only" 😄 that's confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已更改解释
test/README.md
Outdated
@@ -35,6 +35,13 @@ It can be divided into below steps: | |||
2. Prepare resources and install them into cluster, like backend services/deployments. | |||
3. Load conformance tests we choose to open in `e2e_test.go` / `higressTests Slice`, and run them one by one, fail if it is not expected. | |||
|
|||
> Note: You can use `TestArea` flag to control which area you want to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
简单说明要复用e2e环境的步骤是怎样即可,可以加一小节。
另外可以帮忙把这篇README搞一个中文版本吗 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已添加
Signed-off-by: sjcsjc123 <1401189096@qq.com>
@2456868764 之前test-area为setup的时候存在cleanup为true在setup阶段就清除环境的问题。需要重新review。 |
Signed-off-by: sjcsjc123 <1401189096@qq.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Ⅰ. Describe what this PR did
e2e测试优化,实现测试环境复用
Ⅱ. Does this pull request fix one issue?
fixes: #709
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews