-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement the Go Wasm plugin: bot-detect #747
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
==========================================
- Coverage 38.17% 38.14% -0.03%
==========================================
Files 61 61
Lines 10412 10412
==========================================
- Hits 3975 3972 -3
- Misses 6138 6140 +2
- Partials 299 300 +1 |
cc @WeixinX |
@OnlyPiglet Please add an e2e test for it like this PR: #720 |
👌 |
@OnlyPiglet hello,这块e2e test补充有进展吗 |
finished will merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
Implement the Golang version of the existing CPP Wasm plugin: bot-detect
Ⅱ. Does this pull request fix one issue?
fixes #590
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews