Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add devcontainer for wasm-go plugin developing #749

Merged
merged 16 commits into from
Jan 26, 2024

Conversation

rinfx
Copy link
Collaborator

@rinfx rinfx commented Jan 4, 2024

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@rinfx rinfx requested a review from johnlanni as a code owner January 4, 2024 09:53
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e84f998) 38.24% compared to head (a257864) 38.27%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #749      +/-   ##
==========================================
+ Coverage   38.24%   38.27%   +0.03%     
==========================================
  Files          60       60              
  Lines        9979     9979              
==========================================
+ Hits         3816     3819       +3     
+ Misses       5871     5869       -2     
+ Partials      292      291       -1     

see 1 file with indirect coverage changes

@rinfx rinfx closed this Jan 4, 2024
@rinfx rinfx reopened this Jan 4, 2024
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit ccea336 into alibaba:main Jan 26, 2024
11 checks passed
@rinfx rinfx deleted the wasm-go-devcontainer branch June 19, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants