Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wasm support opa (Open Policy Agent) #760

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

baerwang
Copy link
Contributor

@baerwang baerwang commented Jan 7, 2024

Ⅰ. Describe what this PR did

#680

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

https://github.com/alibaba/higress/pull/760/files#diff-42d0e3efd2521fac8aa95701b447893e400e2000cb14c17310abfe560a2c031bR65

image

Ⅴ. Special notes for reviews

@baerwang baerwang force-pushed the wasm/apisix/opa branch 2 times, most recently from ee10bf4 to d9308aa Compare January 7, 2024 13:49
plugins/wasm-go/extensions/opa/main.go Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/opa/main.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e67ed48) 38.17% compared to head (c17689a) 38.17%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #760   +/-   ##
=======================================
  Coverage   38.17%   38.17%           
=======================================
  Files          61       61           
  Lines       10412    10412           
=======================================
  Hits         3975     3975           
  Misses       6138     6138           
  Partials      299      299           

@baerwang baerwang force-pushed the wasm/apisix/opa branch 15 times, most recently from b02a506 to a7dd02c Compare January 11, 2024 00:47
@johnlanni
Copy link
Collaborator

cc @WeixinX

test/e2e/conformance/tests/go-wasm-opa.go Show resolved Hide resolved
plugins/wasm-go/pkg/wrapper/plugin_wrapper.go Outdated Show resolved Hide resolved
plugins/wasm-go/pkg/common/client.go Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/opa/main.go Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/opa/main.go Outdated Show resolved Hide resolved
plugins/wasm-go/extensions/opa/main.go Outdated Show resolved Hide resolved
@baerwang baerwang force-pushed the wasm/apisix/opa branch 3 times, most recently from 36a3022 to 8a97570 Compare January 11, 2024 08:34
@baerwang baerwang force-pushed the wasm/apisix/opa branch 10 times, most recently from fa0f2dc to ea65c30 Compare January 24, 2024 04:58
@baerwang baerwang force-pushed the wasm/apisix/opa branch 3 times, most recently from 6c0a7e9 to 85d1691 Compare January 29, 2024 14:13
@johnlanni
Copy link
Collaborator

@baerwang 整体问题不大了,上面的修复建议调整后就可以合入。感谢🙏

@baerwang baerwang force-pushed the wasm/apisix/opa branch 2 times, most recently from f4da7f8 to 59bed87 Compare January 30, 2024 05:52
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 612c94d into alibaba:main Jan 30, 2024
11 checks passed
@baerwang baerwang deleted the wasm/apisix/opa branch January 30, 2024 12:27
Renz7 pushed a commit to Renz7/higress that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants