-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: wasm support opa (Open Policy Agent) #760
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee10bf4
to
d9308aa
Compare
johnlanni
requested changes
Jan 8, 2024
d9308aa
to
da3058a
Compare
b02a506
to
a7dd02c
Compare
cc @WeixinX |
johnlanni
requested changes
Jan 11, 2024
36a3022
to
8a97570
Compare
johnlanni
reviewed
Jan 18, 2024
fa0f2dc
to
ea65c30
Compare
johnlanni
requested changes
Jan 24, 2024
6c0a7e9
to
85d1691
Compare
johnlanni
reviewed
Jan 30, 2024
johnlanni
reviewed
Jan 30, 2024
@baerwang 整体问题不大了,上面的修复建议调整后就可以合入。感谢🙏 |
85d1691
to
d094644
Compare
johnlanni
reviewed
Jan 30, 2024
johnlanni
reviewed
Jan 30, 2024
johnlanni
reviewed
Jan 30, 2024
f4da7f8
to
59bed87
Compare
59bed87
to
c17689a
Compare
johnlanni
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
#680
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
https://github.com/alibaba/higress/pull/760/files#diff-42d0e3efd2521fac8aa95701b447893e400e2000cb14c17310abfe560a2c031bR65
Ⅴ. Special notes for reviews