fix: bug with close setting of idle timeout #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sjcsjc123 <1401189096@qq.com>
sjcsjc123
requested review from
Xunzhuo,
2456868764,
CH3CHO,
SpecialYang and
johnlanni
as code owners
sjcsjc123
commented
Jan 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
- Coverage 38.11% 38.08% -0.04%
==========================================
Files 61 61
Lines 10323 10329 +6
==========================================
- Hits 3935 3934 -1
- Misses 6089 6096 +7
Partials 299 299
|
Signed-off-by: sjcsjc123 <1401189096@qq.com>
sjcsjc123
commented
Jan 13, 2024
Signed-off-by: sjcsjc123 <1401189096@qq.com>
Signed-off-by: sjcsjc123 <1401189096@qq.com>
|
@johnlanni @2456868764 已修复，e2e测试添加了配置为0的场景，应该符合预期结果的了 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
fix bug with close setting of idle timeout
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
ci pass
Ⅴ. Special notes for reviews