Optimize rds cache #779
Merged
Optimize rds cache #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlanni
requested review from
SpecialYang,
CH3CHO and
Xunzhuo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #779 +/- ##
==========================================
+ Coverage 38.08% 38.12% +0.03%
==========================================
Files 61 61
Lines 10323 10322 -1
==========================================
+ Hits 3932 3935 +3
+ Misses 6091 6088 -3
+ Partials 300 299 -1
|
SpecialYang
reviewed
Jan 17, 2024
| onDemandRDS: true | ||
| hostRDSMergeSubset: true | ||
| onDemandRDS: false | ||
| hostRDSMergeSubset: false |
There was a problem hiding this comment.
onDemandRDS是当启用SRDS时开启on demand；
hostRDSMergeSubset是将域名做合并，解决控制台场景先创建了泛域名，后创建精确域名，可能出现404的问题
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews