Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize destinationRule generate #782

Merged
merged 2 commits into from
Jan 19, 2024

Conversation

johnlanni
Copy link
Collaborator

Ⅰ. Describe what this PR did

Previously, we would also create DR for the HTTP protocol, which is actually meaningless. Moreover, recalculating the DR may cause the port sorting to change during list configstore, triggering a full push. This is also optimized.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (a71ecf4) 38.08% compared to head (a0912c7) 38.07%.
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #782      +/-   ##
==========================================
- Coverage   38.08%   38.07%   -0.02%     
==========================================
  Files          61       61              
  Lines       10323    10337      +14     
==========================================
+ Hits         3932     3936       +4     
- Misses       6091     6101      +10     
  Partials      300      300              
Files Coverage Δ
pkg/ingress/kube/annotations/upstreamtls.go 79.46% <100.00%> (+0.76%) ⬆️
pkg/ingress/config/ingress_config.go 13.45% <0.00%> (-0.12%) ⬇️

@johnlanni johnlanni merged commit d3d0007 into alibaba:main Jan 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants