Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add codecov target for patch #792

Merged
merged 8 commits into from
Jan 26, 2024

Conversation

Uncle-Justice
Copy link
Contributor

@Uncle-Justice Uncle-Justice commented Jan 21, 2024

Ⅰ. Describe what this PR did

  1. 限制开发者提交的PR代码覆盖率不能低于50%,若低于该阈值,CI不予通过

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

自建仓库下执行以下实验:
case1: 当提交的PR自身覆盖率低于阈值时,CI不予通过
image

image

case 2:补充更多用例(含直接调用)后,覆盖率达到阈值,CI通过

image
image

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3d0007) 38.10% compared to head (52f2f03) 38.08%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
- Coverage   38.10%   38.08%   -0.03%     
==========================================
  Files          61       61              
  Lines       10336    10336              
==========================================
- Hits         3939     3936       -3     
- Misses       6098     6100       +2     
- Partials      299      300       +1     

see 1 file with indirect coverage changes

@Uncle-Justice Uncle-Justice marked this pull request as draft January 21, 2024 12:06
@Uncle-Justice Uncle-Justice changed the title test: optimize codecov test: add codecov target for patch Jan 21, 2024
@Uncle-Justice Uncle-Justice marked this pull request as ready for review January 21, 2024 16:05
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 3598c21 into alibaba:main Jan 26, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants