Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify wasm go sdk version #797

Merged
merged 6 commits into from
Jan 26, 2024

Conversation

Uncle-Justice
Copy link
Contributor

Ⅰ. Describe what this PR did

将wasm-go所有插件的wasm-go-sdk包的版本统一为v0.22.0

因为原有的版本下,这些插件无法通过测试

pws@iot:~/higress/plugins/wasm-go/extensions/request-block$ go test ./... -race -coverprofile=coverage.xml -covermode=atomic
# github.com/tetratelabs/proxy-wasm-go-sdk/proxywasm/internal
/home/pws/gowork/pkg/mod/github.com/tetratelabs/proxy-wasm-go-sdk@v0.19.1-0.20220822060051-f9d179a57f8c/proxywasm/internal/hostcall_utils_tinygo.go:31:9: cannot use uintptr(size) (value of type uintptr) as type int in struct literal
/home/pws/gowork/pkg/mod/github.com/tetratelabs/proxy-wasm-go-sdk@v0.19.1-0.20220822060051-f9d179a57f8c/proxywasm/internal/hostcall_utils_tinygo.go:32:9: cannot use uintptr(size) (value of type uintptr) as type int in struct literal
/home/pws/gowork/pkg/mod/github.com/tetratelabs/proxy-wasm-go-sdk@v0.19.1-0.20220822060051-f9d179a57f8c/proxywasm/internal/hostcall_utils_tinygo.go:39:9: cannot use uintptr(size) (value of type uintptr) as type int in struct literal
/home/pws/gowork/pkg/mod/github.com/tetratelabs/proxy-wasm-go-sdk@v0.19.1-0.20220822060051-f9d179a57f8c/proxywasm/internal/hostcall_utils_tinygo.go:40:9: cannot use uintptr(size) (value of type uintptr) as type int in struct literal

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (90f89cf) 38.14% compared to head (a54ba50) 38.14%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #797   +/-   ##
=======================================
  Coverage   38.14%   38.14%           
=======================================
  Files          61       61           
  Lines       10342    10342           
=======================================
  Hits         3945     3945           
  Misses       6098     6098           
  Partials      299      299           

@johnlanni johnlanni merged commit ad4cfdb into alibaba:main Jan 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants