Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hgctl latest version bug #816

Merged
merged 2 commits into from
Feb 3, 2024

Conversation

2456868764
Copy link
Collaborator

Ⅰ. Describe what this PR did

fix: hgctl latest version bug

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7097eef) 38.19% compared to head (23fd5e1) 38.19%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #816   +/-   ##
=======================================
  Coverage   38.19%   38.19%           
=======================================
  Files          61       61           
  Lines       10408    10408           
=======================================
  Hits         3975     3975           
  Misses       6134     6134           
  Partials      299      299           

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 5026973 into alibaba:main Feb 3, 2024
8 checks passed
Renz7 pushed a commit to Renz7/higress that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants