feat: custom listening port for gateway pod in helm #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Uncle-Justice higress controller的代码是不是漏提交了，即环境变量控制转换的逻辑 |
Uncle-Justice
requested review from
SpecialYang,
johnlanni and
CH3CHO
as code owners
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #829 +/- ##
==========================================
+ Coverage 38.04% 38.07% +0.03%
==========================================
Files 61 61
Lines 10428 10434 +6
==========================================
+ Hits 3967 3973 +6
Misses 6161 6161
Partials 300 300
|
johnlanni
requested changes
Feb 21, 2024
| @@ -357,6 +359,26 @@ func (c *controller) ConvertGateway(convertOptions *common.ConvertOptions, wrapp | |||
| return fmt.Errorf("invalid ingress rule %s:%s in cluster %s, either `defaultBackend` or `rules` must be specified", cfg.Namespace, cfg.Name, c.options.ClusterId) | |||
| } | |||
|
|
|||
| // If no ports setting in yaml env(port is parsed as 0), take 80&443 as default. | |||
| gatewayHttpPort, err := strconv.ParseUint(os.Getenv("GATEWAY_HTTP_PORT"), 10, 32) | |||
There was a problem hiding this comment.
每次都取环境变量不太好，可能作为启动参数，实现更简洁一些：
Lines 110 to 115 in b652f3e
Renz7
pushed a commit
to Renz7/higress
that referenced
this pull request
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
使用helm安装higress时，在
values.yaml中自定义gateway pod配置中的监听端口。产生的变化：
Ⅱ. Does this pull request fix one issue?
fixes #734
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
修改values.yaml中监听的http端口后，可在集群内部直接通过对应端口访问到服务
在hostNetwork模式下，可在集群内部观察到envoy监听的端口也发生了对应的变化
Ⅴ. Special notes for reviews