Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: e2e build wasm plugin retry #838

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

baerwang
Copy link
Contributor

@baerwang baerwang commented Feb 22, 2024

Ⅰ. Describe what this PR did

fixes #737

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@baerwang baerwang marked this pull request as ready for review February 22, 2024 11:31
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f537a1c) 38.04% compared to head (0efab29) 38.10%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   38.04%   38.10%   +0.06%     
==========================================
  Files          61       61              
  Lines       10428    10428              
==========================================
+ Hits         3967     3974       +7     
+ Misses       6161     6154       -7     
  Partials      300      300              

see 2 files with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@johnlanni johnlanni merged commit e0e4fc3 into alibaba:main Feb 23, 2024
8 checks passed
@baerwang baerwang deleted the chore/retry branch February 23, 2024 05:52
Renz7 pushed a commit to Renz7/higress that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to compile wasm plugin by tinygo in Actions
3 participants