Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider the new ingress package is available as default #880

Merged
merged 1 commit into from
Mar 26, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Mar 25, 2024

Ⅰ. Describe what this PR did

Consider the new ingress package is available as default, just in case anything goes wrong during initialization, then Higress falls into v1beta1/Ingress and can't recover before restarting.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 38.12%. Comparing base (25c2f6e) to head (f8dc45c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #880      +/-   ##
==========================================
- Coverage   38.13%   38.12%   -0.01%     
==========================================
  Files          61       61              
  Lines       10436    10438       +2     
==========================================
  Hits         3980     3980              
- Misses       6156     6158       +2     
  Partials      300      300              
Files Coverage Δ
pkg/ingress/kube/common/tool.go 50.97% <0.00%> (-0.40%) ⬇️

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 4d6aa25 into alibaba:main Mar 26, 2024
8 checks passed
@CH3CHO CH3CHO deleted the fix/ingress-v1-default branch March 26, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants