Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve error handling in the plugin config model parser of hgctl #891

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Mar 28, 2024

Ⅰ. Describe what this PR did

Improve error handling in the plugin config model parser of hgctl.

  1. Fix typos in variable and method names.
  2. Return field name and related info when unable to parse a specific model field.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 38.15%. Comparing base (08e5678) to head (c7c782a).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
+ Coverage   38.12%   38.15%   +0.02%     
==========================================
  Files          61       61              
  Lines       10438    10438              
==========================================
+ Hits         3980     3983       +3     
+ Misses       6158     6156       -2     
+ Partials      300      299       -1     
Files Coverage Δ
pkg/cmd/hgctl/plugin/types/model_parser.go 69.20% <40.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Collaborator

@WeixinX WeixinX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit dfc9ae4 into alibaba:main Apr 3, 2024
8 checks passed
@CH3CHO CH3CHO deleted the fix/improve-hgctl-error-handling branch April 3, 2024 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants