Feat: transformer plugin support map from body to header #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnlanni
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 38.02% 38.15% +0.12%
==========================================
Files 61 61
Lines 10440 10440
==========================================
+ Hits 3970 3983 +13
+ Misses 6169 6158 -11
+ Partials 301 299 -2 |
johnlanni
force-pushed
the
enhance-transformer-plugin
branch
from
1c799da
to
28d398b
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Previously, this plugin was unable to support parsing parameters from the body and mapping them to headers, queries, etc. Now it is supported, and different rules can use different mapping sources.
For the support of #582, it will be submitted in another PR.
Ⅱ. Does this pull request fix one issue?
fixes #587 (The unfinished part)
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews