Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add e2e testcase for issue 862 #899

Merged

Conversation

dongdongh233
Copy link
Contributor

Ⅰ. Describe what this PR did

  1. Add e2e testcase for timeout annotations.
  2. Route limit e2e: extend test time to reduce errors caused by crossing seconds

Ⅱ. Does this pull request fix one issue?

#861

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

haohandong.hhd added 6 commits March 25, 2024 11:20
add testcases for rate limit annotations
update route limit, qps tolerance from 0.1 to 0.2.
Route limit: extend test time to reduce errors caused by crossing seconds
Add e2e testcases for timeout annotations
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.02%. Comparing base (cba2890) to head (668f6fa).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #899      +/-   ##
==========================================
- Coverage   38.12%   38.02%   -0.10%     
==========================================
  Files          61       61              
  Lines       10440    10440              
==========================================
- Hits         3980     3970      -10     
- Misses       6160     6169       +9     
- Partials      300      301       +1     

see 1 file with indirect coverage changes

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit a8c74c8 into alibaba:main Apr 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants