Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Write the original host header before changed by Wasm plugin into access log #920

Merged
merged 1 commit into from
Apr 23, 2024
Merged

feat: Write the original host header before changed by Wasm plugin into access log #920

merged 1 commit into from
Apr 23, 2024

Conversation

CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Apr 23, 2024

Ⅰ. Describe what this PR did

  1. Allow Wasm plugins to use X-ENVOY-ORIGINAL-HOST header to store the host header by update.
  2. Use the same access log settings in the envoy.yaml file generated by hgctl plugin test create command.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

johnlanni
johnlanni approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CH3CHO CH3CHO merged commit a592b2b into alibaba:main Apr 23, 2024
8 checks passed
@CH3CHO CH3CHO deleted the feat/access-log-original-host branch April 23, 2024 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnlanni johnlanni johnlanni approved these changes

@SpecialYang SpecialYang Awaiting requested review from SpecialYang SpecialYang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@CH3CHO @johnlanni