-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the issue with multiple system prompts when using qwen-long file id mode. #994
Conversation
Signed-off-by: johnlanni <zty98751@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
.DEFAULT: | ||
build: | ||
DOCKER_BUILDKIT=1 docker build --build-arg PLUGIN_NAME=${PLUGIN_NAME} \ | ||
--build-arg BUILDER=${BUILDER} \ | ||
--build-arg GOPROXY=$(GOPROXY) \ | ||
--build-arg EXTRA_TAGS=$(EXTRA_TAGS) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这缩进好像乱了?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我这看好像没乱
@@ -28,6 +30,7 @@ build-image: | |||
DOCKER_BUILDKIT=1 docker build --build-arg PLUGIN_NAME=${PLUGIN_NAME} \ | |||
--build-arg BUILDER=${BUILDER} \ | |||
--build-arg GOPROXY=$(GOPROXY) \ | |||
--build-arg EXTRA_TAGS=$(EXTRA_TAGS) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上,缩进乱了
Ⅰ. Describe what this PR did
When using fileid mode, apart from the system of fileid, Qwen-long only allows one initial system.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews