fix(useExternal): avoid wrong option (#2011)

* fix: type narrowing * chore: update ts type * chore: update * chore: adjust type --------- Co-authored-by: miracles1919 <516571350@qq.com>
alibaba · Feb 16, 2023 · 4d82a07 · 4d82a07
1 parent 17e2f07
commit 4d82a07
Showing 1 changed file with 15 additions and 3 deletions.
diff --git a/packages/hooks/src/useExternal/index.ts b/packages/hooks/src/useExternal/index.ts
@@ -1,10 +1,22 @@
 import { useEffect, useRef, useState } from 'react';
 
-export interface Options {
-  type?: 'js' | 'css';
+type JsOptions = {
+  type: 'js';
   js?: Partial<HTMLScriptElement>;
+};
+
+type CssOptions = {
+  type: 'css';
   css?: Partial<HTMLStyleElement>;
-}
+};
+
+type DefaultOptions = {
+  type?: never;
+  js?: Partial<HTMLScriptElement>;
+  css?: Partial<HTMLStyleElement>;
+};
+
+export type Options = JsOptions | CssOptions | DefaultOptions;
 
 // {[path]: count}
 // remove external when no used