Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support browser history #3736

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Conversation

SoloJiang
Copy link
Collaborator

@SoloJiang SoloJiang commented Oct 29, 2020

  • 修复 web/kraken 同时启动服务的时候,kraken 资源找不到的问题
  • 支持 browser history
  • 统一 debug 输出内容

@codecov-io
Copy link

Codecov Report

Merging #3736 into release-next-rax will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           release-next-rax    #3736   +/-   ##
=================================================
  Coverage             89.72%   89.72%           
=================================================
  Files                    12       12           
  Lines                   146      146           
  Branches                 26       26           
=================================================
  Hits                    131      131           
  Misses                   13       13           
  Partials                  2        2           

try {
debug(config[0]);
debug(configs);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 configs 这个参数。👉👉👉 config

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议修改 build-scripts 的参数

webEntryKeys = Object.keys(getWebpackEntry(config, 'web'));
weexEntryKeys = Object.keys(getWebpackEntry(config, 'weex'));
krakenEntryKeys = Object.keys(getWebpackEntry(config, 'kraken'));
onHook('before.start.run', ({ configs }) => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

@SoloJiang SoloJiang merged commit 8846aff into release-next-rax Oct 29, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix/mutilple-task-resource branch October 29, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants