Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: polyfill load #3777

Merged
merged 11 commits into from
Nov 9, 2020
Merged

Conversation

SoloJiang
Copy link
Collaborator

@SoloJiang SoloJiang changed the base branch from release-next to feat/optimize-webpack-config November 6, 2020 07:59
@SoloJiang SoloJiang changed the title Refactor/polyfill refactor: polyfill load Nov 6, 2020
@@ -11,7 +11,7 @@ const defaultCompileDependencies = [
'strip-ansi'
];
module.exports = (config, compileDependencies) => {
const excludeNodeModules = ![MINIAPP, WECHAT_MINIPROGRAM, BYTEDANCE_MICROAPP].includes(config.taskName);
if ([MINIAPP, WECHAT_MINIPROGRAM, BYTEDANCE_MICROAPP].includes(config.taskName)) return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

返回值统一为 boolean

defaultValue: 'polyfill',
configWebpack: require('./userConfig/injectBabel'),
validation: (val) => {
return validation('injectBabel', val, 'string|boolean');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加个 deprecated 提示

@ClarkXia ClarkXia merged commit d11ec74 into feat/optimize-webpack-config Nov 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor/polyfill branch November 9, 2020 02:50
@SoloJiang SoloJiang mentioned this pull request Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants