fix: when code has declare @jsx createElement comment, swc config runtime: 'classic' #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
reviewed
Feb 27, 2023
| @@ -69,7 +69,18 @@ const plugin: Plugin<CompatRaxOptions> = (options = {}) => ({ | |||
| config.swcOptions = merge(config.swcOptions || {}, { | |||
| compilationConfig: (source: string) => { | |||
| const isRaxComponent = /from\s['"]rax['"]/.test(source); | |||
There was a problem hiding this comment.
package 里面 version 加一下，changelog 补充
There was a problem hiding this comment.
用 changeset 流程：
- 不需要修改版本号
- 项目根路径下执行 pnpm run changeset, 根据 cli 提示操作
- 提交所有文件
There was a problem hiding this comment.
用 changeset 流程：
- 不需要修改版本号
- 项目根路径下执行 pnpm run changeset, 根据 cli 提示操作
- 提交所有文件
这个好像还没有补充到 CONTRIBUTING.md 中
answershuto
reviewed
Feb 27, 2023
| }, | ||
| }, | ||
| }; | ||
| } else if (isRaxComponent) { |
There was a problem hiding this comment.
hasJSXComment 的逻辑放在 isRaxComponent 吧，这个逻辑只在 rax 下生效。
answershuto
reviewed
Feb 27, 2023
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## 0.1.4 | |||
There was a problem hiding this comment.
按照卓凌提的来就好了，这个不需要手动提交了
answershuto
previously approved these changes
Feb 27, 2023
ClarkXia
reviewed
Feb 27, 2023
| @@ -69,7 +69,19 @@ const plugin: Plugin<CompatRaxOptions> = (options = {}) => ({ | |||
| config.swcOptions = merge(config.swcOptions || {}, { | |||
| compilationConfig: (source: string) => { | |||
| const isRaxComponent = /from\s['"]rax['"]/.test(source); | |||
| const hasJSXComment = source.indexOf('@jsx createElement') !== -1; | |||
answershuto
approved these changes
Feb 27, 2023
ClarkXia
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: when code has declare @jsx createElement comment, swc config runtime: 'classic'