-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use latest @iceworks/generate-project to generate scaffold #6025
feat: use latest @iceworks/generate-project to generate scaffold #6025
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/next #6025 +/- ##
===============================================
Coverage ? 81.98%
===============================================
Files ? 197
Lines ? 18177
Branches ? 2369
===============================================
Hits ? 14903
Misses ? 3239
Partials ? 35 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
pluginItemsStr: 'def(),', | ||
}, | ||
optionsStr: `plugins: [ | ||
def(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pluginItemsStr 和 optionsStr 都有 def() ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对,有些模板是用 pluginItemsStr,有些模板有 optionsStr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有点冗余后面可以考虑统一掉
packages/create-ice/src/create.ts
Outdated
const isAliInternal = await checkAliInternal(); | ||
let ejsOptions: Record<string, any> = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个类型可以明确掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
使用
@iceworks/generate-project@2.x
创建脚手架。Close #5720