Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest @iceworks/generate-project to generate scaffold #6025

Merged
merged 4 commits into from
Mar 15, 2023

Conversation

luhc228
Copy link
Collaborator

@luhc228 luhc228 commented Mar 7, 2023

使用 @iceworks/generate-project@2.x 创建脚手架。

Close #5720

@luhc228 luhc228 self-assigned this Mar 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/next@18ea5b2). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/next    #6025   +/-   ##
===============================================
  Coverage                ?   81.98%           
===============================================
  Files                   ?      197           
  Lines                   ?    18177           
  Branches                ?     2369           
===============================================
  Hits                    ?    14903           
  Misses                  ?     3239           
  Partials                ?       35           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@luhc228 luhc228 changed the title [WIP] feat: use latest @iceworks/generate-project to generate scaffold feat: use latest @iceworks/generate-project to generate scaffold Mar 15, 2023
@luhc228 luhc228 added the need review Need Review label Mar 15, 2023
packages/create-ice/package.json Outdated Show resolved Hide resolved
pluginItemsStr: 'def(),',
},
optionsStr: `plugins: [
def(),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pluginItemsStr 和 optionsStr 都有 def() ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对,有些模板是用 pluginItemsStr,有些模板有 optionsStr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有点冗余后面可以考虑统一掉

packages/create-ice/src/create.ts Outdated Show resolved Hide resolved
const isAliInternal = await checkAliInternal();
let ejsOptions: Record<string, any> = {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个类型可以明确掉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@luhc228 luhc228 requested a review from ClarkXia March 15, 2023 09:28
@luhc228 luhc228 merged commit d3f3e68 into release/next Mar 15, 2023
@luhc228 luhc228 deleted the feat/use-latest-generate-project-package branch March 15, 2023 09:56
@luhc228 luhc228 mentioned this pull request Mar 15, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants