fix: pha with data loader #6029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
reviewed
Mar 8, 2023
| const [appConfig, routesConfig, dataloaderConfig] = await Promise.all([getAppConfig(['phaManifest']), getRoutesConfig(), getDataloaderConfig()]); | ||
| const [appConfig, routesConfig] = await Promise.all([getAppConfig(['phaManifest']), getRoutesConfig()]); | ||
|
|
||
| let dataloaderConfig; |
There was a problem hiding this comment.
如果被 catch 了，这个 dataloaderConfig 是一个 undefined，下面处理是否有兜底逻辑，默认给个控对象？
There was a problem hiding this comment.
应该是后续消费的地方，本身做了兼容的，效果等同于没有配 DataLoader
|
CI 报错啦 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release/next #6029 +/- ##
================================================
- Coverage 82.07% 82.05% -0.03%
================================================
Files 197 197
Lines 18090 18132 +42
Branches 2361 2367 +6
================================================
+ Hits 14848 14878 +30
- Misses 3207 3219 +12
Partials 35 35
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
answershuto
reviewed
Mar 8, 2023
| // dataLoader may have side effect code. | ||
| dataloaderConfig = await getDataloaderConfig(); | ||
| } catch (err) { | ||
| logger.debug('PHA: getDataloaderConfig failed.'); |
There was a problem hiding this comment.
logger.debug 是手动打开某个参数才会提示吗？不会透露给用户？
luhc228
reviewed
Mar 8, 2023
packages/ice/src/utils/logger.ts
Outdated
| @@ -53,6 +53,9 @@ export type CreateLoggerReturnType = Pick<Consola, | | |||
| 'debug' | | |||
| 'trace' | |||
| >; | |||
|
|
|||
| export type CreateLogger = (namespace?: ICELogNamespace) => CreateLoggerReturnType; | |||
|
|
|||
| export function createLogger(namespace?: ICELogNamespace): CreateLoggerReturnType { | |||
There was a problem hiding this comment.
如果是上面定义了 CreateLogger 的话，这里建议写成函数表达式
| // dataLoader may have side effect code. | ||
| dataloaderConfig = await getDataloaderConfig(); | ||
| } catch (err) { | ||
| logger.debug('PHA: getDataloaderConfig failed.'); |
answershuto
approved these changes
Mar 9, 2023
luhc228
approved these changes
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果 data loader 存在立即执行代码，增加保护措施，避免报错引起 Manifest 构建失败