fix: redirect named import #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/next #6061 +/- ##
===============================================
Coverage ? 82.06%
===============================================
Files ? 199
Lines ? 18256
Branches ? 2379
===============================================
Hits ? 14982
Misses ? 3240
Partials ? 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
chenjun1011
changed the title
ClarkXia
commented
Mar 15, 2023
luhc228
reviewed
Mar 16, 2023
wssgcg1213
previously approved these changes
Mar 16, 2023
wssgcg1213
previously approved these changes
Mar 16, 2023
luhc228
previously approved these changes
Mar 16, 2023
ClarkXia
dismissed stale reviews from luhc228 and wssgcg1213
The base branch was changed.
luhc228
reviewed
Mar 17, 2023
| @@ -3,8 +3,8 @@ import fse from 'fs-extra'; | |||
| import type { Compiler } from 'webpack'; | |||
| import webpack from '@ice/bundles/compiled/webpack/index.js'; | |||
| import type { Context } from 'build-scripts'; | |||
| import type { ServerCompiler, PluginData } from '../types/plugin.js'; | |||
| import { IMPORT_META_RENDERER, IMPORT_META_TARGET, RUNTIME_TMP_DIR, RUNTIME_EXPORTS } from '../constant.js'; | |||
| import type { ServerCompiler, PluginData, DeclarationData } from '../types/plugin.js'; | |||
There was a problem hiding this comment.
建议是从 packages/ice/src/types/generator.js 导入，DeclarationData 不属于 plugin
| this.serverCompiler = serverCompiler; | ||
| this.rootDir = rootDir; | ||
| this.dataCache = dataCache; | ||
| this.getAllPlugin = getAllPlugin; | ||
| this.target = target; | ||
| this.exportList = exportList; |
There was a problem hiding this comment.
建议在 DataLoaderPlugin 里 exportList 的命名可以显式说明是什么样的 exportList
按照
const exportList = generator.getExportList('framework', target);可以考虑命名为 frameworkExportList
luhc228
approved these changes
Mar 17, 2023
luhc228
approved these changes
Mar 17, 2023
answershuto
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #6059