Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove all exports of routes when render mode is csr #6140

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Apr 7, 2023

SSR and SSG both are disabled, it may also cause server error such as window is undefined when using onDemand compiling.

@ClarkXia ClarkXia requested review from chenjun1011 and luhc228 April 7, 2023 07:18
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/next@48c40ea). Click here to learn what that means.
Patch coverage: 80.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##             release/next    #6140   +/-   ##
===============================================
  Coverage                ?   82.09%           
===============================================
  Files                   ?      200           
  Lines                   ?    18267           
  Branches                ?     2389           
===============================================
  Hits                    ?    14997           
  Misses                  ?     3236           
  Partials                ?       34           
Impacted Files Coverage Δ
packages/ice/src/service/ServerRunner.ts 91.80% <75.00%> (ø)
packages/ice/src/createService.ts 87.98% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClarkXia ClarkXia added the need review Need Review label Apr 10, 2023
@ClarkXia ClarkXia merged commit 7b04ca7 into release/next Apr 11, 2023
@ClarkXia ClarkXia deleted the fix/demand-compile branch April 11, 2023 04:00
@luhc228 luhc228 mentioned this pull request Apr 24, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants