Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getRoutesFile is undefined when use onDemand server #6270

Merged
merged 2 commits into from
May 26, 2023

Conversation

ClarkXia
Copy link
Collaborator

Pass getRoutesFile for onDemand server runner.

@ClarkXia ClarkXia added the need review Need Review label May 24, 2023
chenjun1011
chenjun1011 previously approved these changes May 24, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7cec998) 80.48% compared to head (8389e9b) 80.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6270   +/-   ##
=======================================
  Coverage   80.48%   80.48%           
=======================================
  Files         226      226           
  Lines       20588    20592    +4     
  Branches     2609     2609           
=======================================
+ Hits        16570    16574    +4     
  Misses       3975     3975           
  Partials       43       43           
Impacted Files Coverage Δ
packages/ice/src/createService.ts 87.28% <100.00%> (+0.03%) ⬆️
packages/ice/src/service/ServerRunner.ts 91.91% <100.00%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

luhc228
luhc228 previously approved these changes May 24, 2023
@ClarkXia ClarkXia changed the base branch from master to release/next May 25, 2023 06:29
@ClarkXia ClarkXia dismissed stale reviews from luhc228 and chenjun1011 May 25, 2023 06:29

The base branch was changed.

@ClarkXia ClarkXia changed the title hotfix: getRoutesFile is undefined when use onDemand server fix: getRoutesFile is undefined when use onDemand server May 25, 2023
@ClarkXia ClarkXia requested a review from luhc228 May 25, 2023 09:00
@ClarkXia ClarkXia merged commit 94e7dff into release/next May 26, 2023
@ClarkXia ClarkXia deleted the fix/on-demand branch May 26, 2023 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants