fix: ssr error handle #6278
Merged
fix: ssr error handle #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
answershuto
previously approved these changes
May 29, 2023
ClarkXia
reviewed
May 29, 2023
| @@ -160,6 +160,7 @@ export async function renderToResponse(requestContext: ServerContext, renderOpti | |||
| onShellError: async (err) => { | |||
| if (renderOptions.disableFallback) { | |||
| reject(err); | |||
| return; | |||
ClarkXia
approved these changes
May 29, 2023
answershuto
approved these changes
May 29, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/next #6278 +/- ##
===============================================
Coverage ? 80.52%
===============================================
Files ? 226
Lines ? 20597
Branches ? 2611
===============================================
Hits ? 16586
Misses ? 3968
Partials ? 43
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reject error 后需要 return，避免进入后续逻辑