chore: weex support for ice appear #6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/next #6391 +/- ##
===============================================
Coverage ? 80.26%
===============================================
Files ? 238
Lines ? 21502
Branches ? 2650
===============================================
Hits ? 17259
Misses ? 4199
Partials ? 44 ☔ View full report in Codecov by Sentry. |
|
pr 描述需要补全 |
answershuto
reviewed
Jul 17, 2023
answershuto
reviewed
Jul 17, 2023
luhc228
reviewed
Jul 18, 2023
linbudu599
requested review from
wssgcg1213,
luhc228 and
answershuto
and removed request for
wssgcg1213
wssgcg1213
approved these changes
Jul 26, 2023
luhc228
approved these changes
Jul 26, 2023
myhere
reviewed
Nov 27, 2023
| onAppear && nodeRef?.addEventListener('appear', (e: CustomEvent) => onAppear(e)); | ||
|
|
||
| return () => { | ||
| onAppear && nodeRef?.removeEventListener('appear', (e: CustomEvent) => onAppear(e)); |
There was a problem hiding this comment.
hi，@linbudu599 weex 下 addEventListener、removeEventListener 对 onAppear 都加了一层 wrapper，所以这里 removeEventListener 是不是就不生效了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在 @ice/appear 中直接支持 Weex 组件分发。
场景：业务项目为启用了 rax-compat 的 ICE 项目，rax-compat 内部直接引入了 @ice/appear 作为 appear-polyfill 支持，而该项目有 Weex 场景支持，将 @ice/appear alias 到了跨端组件库内的 @ali/ice-appear 组件，而 @ali/ice-appear 组件内又依赖了 @ice/appear，导致了循环依赖。