Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build warning of runApp is not exported #6438

Merged
merged 3 commits into from
Aug 3, 2023

Conversation

ClarkXia
Copy link
Collaborator

@ClarkXia ClarkXia commented Aug 3, 2023

Default imported will cause build warning when attempt to access props which is not exported in IIFE.

image

@ClarkXia ClarkXia changed the base branch from master to release/next August 3, 2023 03:01
@ClarkXia ClarkXia added the need review Need Review label Aug 3, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (67eae5c) 80.16% compared to head (b4fc9e8) 80.16%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/next    #6438   +/-   ##
=============================================
  Coverage         80.16%   80.16%           
=============================================
  Files               239      239           
  Lines             21559    21555    -4     
  Branches           2652     2652           
=============================================
- Hits              17282    17279    -3     
+ Misses             4233     4232    -1     
  Partials             44       44           
Files Changed Coverage Δ
packages/ice/src/createService.ts 88.53% <100.00%> (-0.12%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ClarkXia ClarkXia merged commit 9978372 into release/next Aug 3, 2023
@ClarkXia ClarkXia deleted the fix/runapp-warning branch August 3, 2023 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need review Need Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants