Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve miniapp #6985

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: improve miniapp #6985

wants to merge 1 commit into from

Conversation

XGHeaven
Copy link
Collaborator

@XGHeaven XGHeaven commented Sep 4, 2024

No description provided.

@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

@XGHeaven XGHeaven force-pushed the feat/miniapp branch 8 times, most recently from 3a99204 to 8a12b36 Compare September 10, 2024 06:42
@XGHeaven XGHeaven force-pushed the feat/miniapp branch 4 times, most recently from 1dc7df9 to 6ae900b Compare September 19, 2024 12:21
@XGHeaven XGHeaven force-pushed the feat/miniapp branch 2 times, most recently from 422ac13 to 23d428d Compare October 11, 2024 07:32
@XGHeaven XGHeaven force-pushed the feat/miniapp branch 4 times, most recently from 4a9c48d to 67c1295 Compare October 22, 2024 08:19
@XGHeaven XGHeaven marked this pull request as ready for review October 22, 2024 08:26
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 19.54023% with 70 lines in your changes missing coverage. Please review.

Project coverage is 79.09%. Comparing base (37c4278) to head (0a806a9).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
packages/ice/src/bundler/webpack/start.ts 0.00% 24 Missing ⚠️
packages/miniapp-runtime/src/dom/event.ts 23.80% 16 Missing ⚠️
packages/miniapp-runtime/src/dom/event-target.ts 25.00% 12 Missing ⚠️
packages/route-manifest/src/index.ts 26.66% 11 Missing ⚠️
packages/miniapp-runtime/src/hydrate.ts 0.00% 4 Missing ⚠️
packages/miniapp-runtime/src/dom/root.ts 33.33% 2 Missing ⚠️
packages/ice/src/bundler/webpack/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6985      +/-   ##
==========================================
+ Coverage   79.08%   79.09%   +0.01%     
==========================================
  Files         221      220       -1     
  Lines       19715    19654      -61     
  Branches     2506     2508       +2     
==========================================
- Hits        15592    15546      -46     
+ Misses       4085     4068      -17     
- Partials       38       40       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@XGHeaven XGHeaven force-pushed the feat/miniapp branch 2 times, most recently from 441c21c to 13f7a02 Compare October 25, 2024 04:27
@ClarkXia
Copy link
Collaborator

CI 的问题可以先解决了

@XGHeaven
Copy link
Collaborator Author

@ClarkXia CI 已经解决了

packages/ice/package.json Show resolved Hide resolved
packages/ice/templates/core/env.ts.ejs Show resolved Hide resolved
packages/route-manifest/src/index.ts Outdated Show resolved Hide resolved
ChrisCindy
ChrisCindy previously approved these changes Nov 6, 2024
@ClarkXia ClarkXia changed the base branch from master to release/next November 7, 2024 07:24
@ClarkXia ClarkXia dismissed ChrisCindy’s stale review November 7, 2024 07:24

The base branch was changed.

@ClarkXia ClarkXia changed the base branch from release/next to master November 7, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants