feat: support follow_redirects, tls #1896
Open
+261
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catdogpandas
changed the title
messixukejia
requested changes
Nov 19, 2024
henryzhx8
reviewed
Nov 20, 2024
henryzhx8
approved these changes
Nov 21, 2024
linrunqi08
reviewed
Nov 25, 2024
| struct CurlTLS { | ||
| std::string mCaFile; | ||
| std::string mCertFile; | ||
| std::string mKeyFile; |
There was a problem hiding this comment.
一般配置是：ca_file: /var/run/secrets/kubernetes.io/serviceaccount/ca.crt，这个是 POD 里面自带的
如果用户有额外需求，就自己配置
There was a problem hiding this comment.
我这里说一下，在ACK组件形态下，肯定不允许客户自己配置的。这块我之前提过固定挂一个configmap到某个路径下，这样客户自己可以去configmap中修改，而不动部署模版
There was a problem hiding this comment.
我这里说一下，在ACK组件形态下，肯定不允许客户自己配置的。这块我之前提过固定挂一个configmap到某个路径下，这样客户自己可以去configmap中修改，而不动部署模版
这里不单是 ACK 组件形态，后面托管探针、集团生产环境（另一套组件）需要用到自定义挂载 CA File 才能采集
messixukejia
approved these changes
Nov 25, 2024
linrunqi08
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.