feat: update spring, support jedis cluster pipeline #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roiocam
force-pushed
the
update-spring
branch
2 times, most recently
from
5b2c109
to
1c4dfd9
Compare
Roiocam
commented
Mar 22, 2024
| AtomicInteger loadSuccess = new AtomicInteger(0); | ||
| Function loader = k -> { | ||
| final Duration SHORT_PROTECT_DURATION = Duration.ofMillis(1); | ||
| final Duration LONG_PROTECT_DURATION = Duration.ofSeconds(60); |
There was a problem hiding this comment.
穿透保护相关的单测涉及到线程执行效率都比较 flaky，我重写了一版，应该不会改变语义
|
现在另一个pr里面已经能比较好put all的pipeline问题，那么升级依赖是否还有必要性？并不是spring、jedis有升级这边就同步升级的，而是仅在必要的时候升级。否则升级2.8了，但是又看不到新功能，反而兼容性会有所变更，意义就不大。 另外，其它的几个修改点，是否互相相关？如果不是，我建议拆一下，否则这个pr太大了，不好review。 |
不是非常有必要，主要是 jedis 的 api 可能流畅些，另外升级的时候遇到 redisson 的升级时可能的一些问题，算是提前踩坑了
Spring 升级的时候有一些相关的：
除此之外就是有个单测表现得很 flaky，导致 PR 的 CI 过不去。 另一个 PR 可以满足，如果近期没升级 Spring 及相关依赖的计划，那么这个 PR 我就关了 |
|
如果出现重大兼容性问题，比如某个依赖升级版本以后，jetcache无法运行基本功能，会考虑升级 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolve #865 at 2.8.x