Optimize code quality.

alibaba · Dec 13, 2024 · 6683dec · 6683dec
1 parent f5a5968
commit 6683dec
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 6 deletions.
diff --git a/config/src/main/java/com/alibaba/nacos/config/server/controller/HistoryController.java b/config/src/main/java/com/alibaba/nacos/config/server/controller/HistoryController.java
@@ -103,16 +103,14 @@ public ConfigHistoryInfo getConfigHistoryInfo(@RequestParam("dataId") String dat
     }
 
     /**
-     * Query the detailed configuration history information pair,
-     * including the original version and the updated version. notes:
+     * Query the detailed configuration history information pair, including the original version and the updated version. notes:
      *
      * @param nid    history_config_info nid
      * @param dataId dataId  @since 2.0.3
      * @param group  groupId  @since 2.0.3
      * @param tenant tenantId  @since 2.0.3
      * @return history config info
      * @since 2.0.3 add {@link Secured}, dataId, groupId and tenant for history config permission check.
-     * @since 1.4.0
      */
     @GetMapping(value = "/pair")
     @Secured(action = ActionTypes.READ, signType = SignType.CONFIG)

diff --git a/config/src/main/java/com/alibaba/nacos/config/server/model/ConfigHistoryInfoPair.java b/config/src/main/java/com/alibaba/nacos/config/server/model/ConfigHistoryInfoPair.java
@@ -20,7 +20,7 @@
 import java.util.Objects;
 
 /**
- * ConfigHistoryInfo including updated info.
+ * extensible {@link ConfigHistoryInfo}.
  */
 public class ConfigHistoryInfoPair extends ConfigHistoryInfo implements Serializable {
 

diff --git a/config/src/main/java/com/alibaba/nacos/config/server/service/HistoryService.java b/config/src/main/java/com/alibaba/nacos/config/server/service/HistoryService.java
@@ -120,8 +120,7 @@ private void checkHistoryInfoPermission(ConfigHistoryInfo configHistoryInfo, Str
     }
 
     /**
-     * Query the detailed configuration history information pair,
-     * including the original version and the updated version.
+     * Query the detailed configuration history information pair, including the original version and the updated version.
      */
     public ConfigHistoryInfoPair getConfigHistoryInfoPair(String dataId, String group, String namespaceId, Long nid)
             throws AccessException {

diff --git a/.../nacos/config/server/service/repository/extrnal/ExternalConfigInfoPersistServiceImpl.java b/.../nacos/config/server/service/repository/extrnal/ExternalConfigInfoPersistServiceImpl.java
@@ -176,6 +176,7 @@ public ConfigOperateResult addConfigInfo(final String srcIp, final String srcUse
      * @param configAdvanceInfo advance info
      * @return
      */
+    @Override
     public ConfigOperateResult insertOrUpdate(String srcIp, String srcUser, ConfigInfo configInfo,
             Map<String, Object> configAdvanceInfo) {
         try {