Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #9954] Unified use of millisecond time units #10004

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

YunWZ
Copy link
Contributor

@YunWZ YunWZ commented Feb 24, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

Unified use of millisecond time units

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

Codecov Report

Merging #10004 (0b079c9) into develop (7ca8c59) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10004      +/-   ##
=============================================
- Coverage      50.69%   50.59%   -0.11%     
+ Complexity      4849     4839      -10     
=============================================
  Files            865      865              
  Lines          27507    27507              
  Branches        3034     3034              
=============================================
- Hits           13944    13916      -28     
- Misses         12329    12364      +35     
+ Partials        1234     1227       -7     
Impacted Files Coverage Δ
...ba/nacos/core/remote/grpc/GrpcServerConstants.java 85.71% <100.00%> (ø)
...in/java/com/alibaba/nacos/sys/utils/InetUtils.java 31.03% <0.00%> (-24.14%) ⬇️
...m/alibaba/nacos/naming/misc/HttpClientManager.java 50.00% <0.00%> (-8.58%) ⬇️
...os/client/auth/ram/identify/CredentialService.java 76.08% <0.00%> (+4.34%) ⬆️
...ent/manager/impl/ConnectionBasedClientManager.java 81.13% <0.00%> (+7.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ca8c59...0b079c9. Read the comment docs.

@KomachiSion KomachiSion merged commit aebe583 into alibaba:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GrpcClient] The thread name may be incorrect after reconect to the next server
3 participants