Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10038]load failover file. #10048

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Conversation

YunWZ
Copy link
Contributor

@YunWZ YunWZ commented Mar 6, 2023

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #10038

Brief changelog

  1. set failover switch file path like: /path/to/serviceinfo/failover/00-00---000-VIPSRV_FAILOVER_SWITCH-000---00-00 instead of /path/to/serviceinfo/failover00-00---000-VIPSRV_FAILOVER_SWITCH-000---00-00;
  2. Correctly load the failover file

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2023

Codecov Report

Merging #10048 (70e952a) into develop (000f943) will increase coverage by 0.03%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #10048      +/-   ##
=============================================
+ Coverage      50.63%   50.66%   +0.03%     
- Complexity      4833     4840       +7     
=============================================
  Files            864      864              
  Lines          27462    27449      -13     
  Branches        3033     3031       -2     
=============================================
+ Hits           13905    13908       +3     
+ Misses         12331    12307      -24     
- Partials        1226     1234       +8     
Impacted Files Coverage Δ
...a/nacos/client/naming/backups/FailoverReactor.java 30.57% <16.66%> (-0.26%) ⬇️
...com/alibaba/nacos/api/naming/pojo/ServiceInfo.java 94.44% <100.00%> (+0.21%) ⬆️
.../core/v2/event/publisher/NamingEventPublisher.java 68.35% <0.00%> (-7.60%) ⬇️
...ent/manager/impl/ConnectionBasedClientManager.java 73.58% <0.00%> (-7.55%) ⬇️
...os/client/auth/ram/identify/CredentialService.java 71.73% <0.00%> (-4.35%) ⬇️
...in/java/com/alibaba/nacos/sys/utils/InetUtils.java 55.17% <0.00%> (+24.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 000f943...70e952a. Read the comment docs.

Copy link
Collaborator

@KomachiSion KomachiSion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我觉得修复方法有错误, 不应该在ServiceInfo里面去URLDecoder, ServiceInfo不感知这是不是文件。

应该在调用处进行decoder

@YunWZ
Copy link
Contributor Author

YunWZ commented Mar 8, 2023

我觉得修复方法有错误, 不应该在ServiceInfo里面去URLDecoder, ServiceInfo不感知这是不是文件。

应该在调用处进行decoder

已修改。

@KomachiSion KomachiSion merged commit 62ef024 into alibaba:develop Mar 9, 2023
@KomachiSion KomachiSion added this to the 2.2.1 milestone Mar 9, 2023
@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/bug Category issues or prs related to bug. labels Mar 9, 2023
@YunWZ YunWZ deleted the hotfix/10038 branch December 11, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

启用故障转移时产生的问题
3 participants