Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize nacos client #10555

Merged
merged 1 commit into from
May 26, 2023
Merged

optimize nacos client #10555

merged 1 commit into from
May 26, 2023

Conversation

shiyiyue1102
Copy link
Collaborator

  1. notify thread change to one thread to avoid potential ClassLoader switch exception
  2. optimize current notify ,add receiveNotifyChanged flag
  3. add notify block log for over 60s
  4. add notify error & block stack trace
  5. fix shutdown client worker memory leak  of server list change subscriber
  6. use multi thread for different  task id  for sync with server to speed up config sync.
  7. fix exception when request with 0 or negative timeouts.
  8. simply local snapshot path  when env name over 50 chars
  9. add a random sleep in health check for avoid health check syntony.

@shiyiyue1102
1. notify thread change to one thread to avoid potential ClassLoader …
748b6ba 
…switch exception

2. optimize current notify ,add receiveNotifyChanged flag
3. add notify block log for over 60s
4. add notify error & block stack trace
5. fix shutdown client worker memory leak  of server list change subscriber
6. use multi thread for different  task id  for sync with server to speed up config sync.
7. fix exception when request with 0 or negative timeouts.
8. simply local snapshot path  when env name over 50 chars
9. add a random sleep in health check for avoid health check syntony.
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Client Related to Nacos Client SDK labels May 26, 2023
@KomachiSion KomachiSion added this to the 2.3.0 milestone May 26, 2023
@KomachiSion KomachiSion merged commit 83ee4c8 into alibaba:develop May 26, 2023
@shiyiyue1102 shiyiyue1102 deleted the develop_optimize_client branch May 26, 2023 09:13
KomachiSion pushed a commit that referenced this pull request Jun 20, 2023
@shiyiyue1102 @KomachiSion
1. notify thread change to one thread to avoid potential ClassLoader …
bbeb069 
…switch exception (#10555)

2. optimize current notify ,add receiveNotifyChanged flag
3. add notify block log for over 60s
4. add notify error & block stack trace
5. fix shutdown client worker memory leak  of server list change subscriber
6. use multi thread for different  task id  for sync with server to speed up config sync.
7. fix exception when request with 0 or negative timeouts.
8. simply local snapshot path  when env name over 50 chars
9. add a random sleep in health check for avoid health check syntony.
wukong121 pushed a commit to wukong121/nacos that referenced this pull request Aug 4, 2023
@shiyiyue1102 @wukong121
1. notify thread change to one thread to avoid potential ClassLoader …
fa977ee 
…switch exception (alibaba#10555)

2. optimize current notify ,add receiveNotifyChanged flag
3. add notify block log for over 60s
4. add notify error & block stack trace
5. fix shutdown client worker memory leak  of server list change subscriber
6. use multi thread for different  task id  for sync with server to speed up config sync.
7. fix exception when request with 0 or negative timeouts.
8. simply local snapshot path  when env name over 50 chars
9. add a random sleep in health check for avoid health check syntony.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KomachiSion KomachiSion KomachiSion approved these changes

Assignees
No one assigned
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shiyiyue1102 @KomachiSion