Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reflect-config.json #11860

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Update reflect-config.json #11860

merged 1 commit into from
Mar 26, 2024

Conversation

lmm1990
Copy link
Contributor

@lmm1990 lmm1990 commented Mar 20, 2024

add deletion graalvm reflect config

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #11853

Brief changelog

client/src/main/resources/META-INF/native-image/com.alibaba.nacos/nacos-client/reflect-config.json

perfect config
ConfigChangeNotifyRequest
NotifySubscriberRequest
ConnectionSetupRequest
AbstractConfigRequest

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

add deletion graalvm reflect config
@CLAassistant
Copy link

CLAassistant commented Mar 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I run it on my local, It is working.

@KomachiSion KomachiSion added area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement. labels Mar 25, 2024
@KomachiSion KomachiSion merged commit ec4f215 into alibaba:develop Mar 26, 2024
7 checks passed
@KomachiSion KomachiSion modified the milestones: 2.4.0, 2.3.2 Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Client Related to Nacos Client SDK kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraalVM support for nacos-client
4 participants