[ISSUE #12342]: Improve the retrieval of ConfigInfoState to facilitate the extension and implementation of databases like Oracle. #12343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and implementation of databases like Oracle.
|
Can you add unit test for this? |
…foPersistServiceImpl#findConfigInfoState` method.
The SQL construction logic of the |
|
I see the CLA has no signed. Can you sign the CLA? |
KomachiSion
previously approved these changes
Jul 18, 2024
CLA has been signed. |
… using a unified appendWhereClause method to construct the WHERE clause. Modify appendWhereClause to be protected, allowing for customization based on different database types, such as adjustments according to column names.
gongycn
changed the title
|
@KomachiSion Could this change be merged? Thank you. |
KomachiSion
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
fixes #12342
Improve the retrieval of ConfigInfoState to facilitate the extension and implementation of databases like Oracle.
Brief changelog
Generate the SQL required by
ExternalConfigInfoPersistServiceImpl#findConfigInfoStateusing theselectmethod fromMapperManager.Verifying this change
We have already used this method in the production environment, adapting the configuration management for both Oracle and MySQL databases.