Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix config query notify delay #13050

Merged
merged 10 commits into from
Jan 17, 2025
Merged

Conversation

shiyiyue1102
Copy link
Collaborator

fix config query notify delay

Copy link

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage/api/configuration change such as Add new API , Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/next/ for repository nacos-group/nacos-group.github.io


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式/API/配置参数的变更,如:新增API新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库nacos-group/nacos-group.github.io中的docs/next/目录下添加或更新文档(markdown格式)。

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.31%. Comparing base (8a136c2) to head (c25616c).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             develop   #13050      +/-   ##
=============================================
- Coverage      72.34%   72.31%   -0.04%     
- Complexity     10023    10026       +3     
=============================================
  Files           1310     1310              
  Lines          42004    42004              
  Branches        4413     4411       -2     
=============================================
- Hits           30388    30375      -13     
- Misses          9493     9522      +29     
+ Partials        2123     2107      -16     
Files with missing lines Coverage Δ
...s/config/server/controller/ConfigServletInner.java 73.28% <100.00%> (+0.76%) ⬆️
...onfig/server/remote/ConfigQueryRequestHandler.java 86.66% <100.00%> (+1.66%) ⬆️

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a136c2...c25616c. Read the comment docs.

@KomachiSion KomachiSion merged commit 90d3469 into alibaba:develop Jan 17, 2025
8 checks passed
@KomachiSion KomachiSion added this to the 2.5.0 milestone Jan 17, 2025
@KomachiSion KomachiSion added kind/bug Category issues or prs related to bug. area/Config labels Jan 17, 2025
@wuyfee
Copy link

wuyfee commented Jan 17, 2025

$\color{green}{SUCCESS}$
DETAILS
✅ - docker: success
✅ - deploy (standalone & cluster & standalone_auth): success
✅ - e2e-java-test (standalone & cluster & standalone_auth): success
✅ - e2e-go-test (standalone & cluster): success
✅ - e2e-cpp-test (standalone & cluster): success
✅ - e2e-csharp-test (standalone & cluster): success
✅ - e2e-nodejs-test (standalone & cluster): success
✅ - e2e-python-test (standalone & cluster): success
✅ - clean (standalone & cluster & standalone_auth): success

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Config kind/bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants