Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1839]add ContentType return while getConfig #3470

Merged
merged 1 commit into from
Jul 31, 2020

Conversation

wangweizZZ
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#1839

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@zongtanghu
Copy link
Collaborator

The CI test cases has failed, please check it.@wangwei

@wangweizZZ
Copy link
Collaborator Author

ci had passed .please help review this pr @zongtanghu @KomachiSion

@zongtanghu zongtanghu requested review from KomachiSion, chuntaojun and zongtanghu and removed request for KomachiSion July 29, 2020 09:53
@zongtanghu zongtanghu added the kind/enhancement Category issues or prs related to enhancement. label Jul 29, 2020
@zongtanghu zongtanghu added this to the 1.3.2 milestone Jul 29, 2020
@zongtanghu
Copy link
Collaborator

Please help to review this pr. @KomachiSion @chuntaojun

@chuntaojun chuntaojun merged commit 43f6065 into alibaba:develop Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants