[ISSUE-#4115] Refactor client naming event handle logic #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
requested changes
Nov 5, 2020
There was a problem hiding this comment.
add unsubscribeAsyncHandle and subscribeAsyncHandle is not really reasonable, I think.
If you want to enhance async handle listener, I remember client-config has one kind of implementation. Maybe you can refer it.
If you want to enhance event dispatcher. I think only to replace it with NotifyCenter is enough.
…compatible old version.
solve it |
Maijh97
requested changes
Nov 5, 2020
api/src/main/java/com/alibaba/nacos/api/naming/listener/EventListener.java
Outdated
Show resolved
Hide resolved
… handle naming event.
…cutor and InstanceChangeListener's executor
2.fix getSubscribeServices
chuntaojun
reviewed
Nov 7, 2020
api/src/main/java/com/alibaba/nacos/api/naming/listener/AbstractEventListener.java
Outdated
Show resolved
Hide resolved
chuntaojun
reviewed
Nov 7, 2020
client/src/main/java/com/alibaba/nacos/client/naming/core/HostReactor.java
Outdated
Show resolved
Hide resolved
client/src/main/java/com/alibaba/nacos/client/naming/event/InstancesChangeEvent.java
Show resolved
Hide resolved
client/src/main/java/com/alibaba/nacos/client/naming/event/InstancesChangeNotifier.java
Outdated
Show resolved
Hide resolved
KomachiSion
requested changes
Nov 9, 2020
api/src/main/java/com/alibaba/nacos/api/naming/listener/AbstractEventListener.java
Show resolved
Hide resolved
KomachiSion
previously approved these changes
Nov 10, 2020
Maijh97
requested changes
Nov 10, 2020
done |
KomachiSion
reviewed
Nov 10, 2020
common/src/main/java/com/alibaba/nacos/common/notify/EventPublisher.java
Outdated
Show resolved
Hide resolved
Maijh97
requested changes
Nov 11, 2020
client/src/main/java/com/alibaba/nacos/client/naming/event/InstancesChangeNotifier.java
Outdated
Show resolved
Hide resolved
chuntaojun
reviewed
Nov 11, 2020
client/src/main/java/com/alibaba/nacos/client/naming/core/HostReactor.java
Outdated
Show resolved
Hide resolved
KomachiSion
previously approved these changes
Nov 12, 2020
chuntaojun
reviewed
Nov 12, 2020
client/src/main/java/com/alibaba/nacos/client/naming/core/HostReactor.java
Outdated
Show resolved
Hide resolved
chuntaojun
approved these changes
Nov 12, 2020
Maijh97
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
issue-#4115