Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #3102] add commons-lang3 dependency into core and sys #4198

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

corey89757
Copy link
Contributor

@corey89757 corey89757 commented Nov 11, 2020

##What is the purpose of the change

add commons-lang3 dependency into core and sys.

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

…g/lang3 dependency in common/api/client.

Change-Id: I4b7a0bec09359e64ecf997b123b85c265bfe16cf
@corey89757
Copy link
Contributor Author

After this phase, I will move lang dependency to lang3 dependency in server modules. Then I can remove lang/lang3 dependency in client/api/model module.

@KomachiSion KomachiSion merged commit bc7a153 into alibaba:develop Nov 11, 2020
@KomachiSion KomachiSion added the dependencies Pull requests that update a dependency file label Nov 11, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants