Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #4412]: Update comment error #4413

Merged
merged 2 commits into from
Dec 7, 2020
Merged

[ISSUE #4412]: Update comment error #4413

merged 2 commits into from
Dec 7, 2020

Conversation

xuande
Copy link
Contributor

@xuande xuande commented Dec 5, 2020

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

#4412

Brief changelog

Modify the types of pageNo and pageSize

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@Maijh97 Maijh97 changed the title fixes[#4412]: Update comment error [ISSUE #4412]: Update comment error Dec 6, 2020
@KomachiSion KomachiSion added this to the 1.4.1 milestone Dec 7, 2020
@KomachiSion KomachiSion linked an issue Dec 7, 2020 that may be closed by this pull request
@KomachiSion KomachiSion merged commit b9a842c into alibaba:master Dec 7, 2020
@KomachiSion KomachiSion added status/invalid This doesn't seem right and removed kind/code quality labels Dec 7, 2020
@KomachiSion KomachiSion removed this from the 1.4.1 milestone Dec 7, 2020
KomachiSion added a commit that referenced this pull request Dec 7, 2020
KomachiSion added a commit that referenced this pull request Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

history configuration api comment error
4 participants