Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE#4355] Do not retry distro sync again if member has removed. #4586

Merged
merged 1 commit into from
Dec 29, 2020

Conversation

KomachiSion
Copy link
Collaborator

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

For #4355 .

Brief changelog

Do not retry distro sync again if member has removed.

Verifying this change

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@KomachiSion KomachiSion added this to the 1.4.1 milestone Dec 28, 2020
@KomachiSion KomachiSion added kind/enhancement Category issues or prs related to enhancement. area/Nacos Core labels Dec 28, 2020
Copy link
Collaborator

@horizonzy horizonzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this logic is same effect on config data notify.

@@ -35,8 +36,17 @@
*/
public class DistroHttpAgent implements DistroTransportAgent {

private final ServerMemberManager memberManager;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And can we transfer a static method to check targetServer in memberManager, the logic maybe used in other place. When we want to use the logic, didn't inject memberManager.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too Many static method and object will caused over-coupling, and hard to modified and refactor

@KomachiSion KomachiSion merged commit 00d4363 into alibaba:develop Dec 29, 2020
@KomachiSion KomachiSion deleted the develop-issue4355 branch January 7, 2021 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/Nacos Core kind/enhancement Category issues or prs related to enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants