[ISSUE#6116] Refactor ClientManager and make register client and schedule checkTask is atomic. #6118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomachiSion
force-pushed
the
develop-issue#6116
branch
2 times, most recently
from
780ee08 to
9563b7b
Compare
… schedule checkTask is atomic.
KomachiSion
force-pushed
the
develop-issue#6116
branch
from
9563b7b to
2237cc8
Compare
pixystone
suggested changes
Jun 21, 2021
| @@ -170,7 +171,10 @@ public Response onApply(WriteRequest request) { | |||
|
|
|||
| private void onInstanceRegister(Service service, Instance instance, String clientId) { | |||
| Service singleton = ServiceManager.getInstance().getSingleton(service); | |||
| Client client = clientManager.computeIfAbsent(clientId, () -> new IpPortBasedClient(clientId, false)); | |||
| if (!clientManager.contains(clientId)) { | |||
There was a problem hiding this comment.
This contains is unnecessary.
There was a problem hiding this comment.
To reduce invalid object create. When the node handle the register persistent instance, the client has been create and register. There is no need to create and try create again.
pixystone
suggested changes
Jun 21, 2021
| @@ -289,6 +293,7 @@ protected void loadSnapshot(byte[] snapshotBytes) { | |||
| ConcurrentHashMap<String, IpPortBasedClient> snapshot = new ConcurrentHashMap<>(newData.size()); | |||
| for (Map.Entry<String, ClientSyncData> entry : newData.entrySet()) { | |||
| IpPortBasedClient snapshotClient = new IpPortBasedClient(entry.getKey(), false); | |||
There was a problem hiding this comment.
Consider using factory ?
There was a problem hiding this comment.
Using factory will add multiple dependencies. So I think no neccessary.
horizonzy
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not create a Pull Request without creating an issue first.
What is the purpose of the change
Fixes #6116 .
Brief changelog
Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily:
[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=trueto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.